[spark] SparkFilterConverter: support AlwaysTrue/False, fix silent NaN drop#8060
Merged
Merged
Conversation
…rkFilterConverter * Add AlwaysTrue / AlwaysFalse to the list of supported Spark filters and translate them to the corresponding Paimon predicates. * Intercept EqualTo with a NaN Float/Double literal and push it down as an IsNaN predicate, since Spark's EqualTo treats NaN as equal to NaN while Paimon's equality predicate would not match any row. * Drop the two obsolete TODOs covered by the changes above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
fix two TODOs in
SparkFilterConverter:AlwaysTrue/AlwaysFalsecol = NaNtoIsNaN(col)— Spark treatsNaN = NaNas true, Paimon doesn't, so NaN rows were getting silently dropped on pushdown.Tests
SparkFilterConverterTest#testAlwaysTrueFalse,#testEqualToNaN.